[
https://issues.apache.org/jira/browse/AMBARI-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317416#comment-15317416
]
Hadoop QA commented on AMBARI-17067:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12808423/diff1-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
contrib/management-packs/microsoft-r_mpack.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7196//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7196//console
This message is automatically generated.
> Microsoft-r install script should use Ambari libraries instead of direct
> shell calls
> ------------------------------------------------------------------------------------
>
> Key: AMBARI-17067
> URL: https://issues.apache.org/jira/browse/AMBARI-17067
> Project: Ambari
> Issue Type: Task
> Components: contrib
> Affects Versions: 2.4.0
> Reporter: Balázs Bence Sári
> Assignee: Balázs Bence Sári
> Priority: Critical
> Fix For: 2.4.1
>
> Attachments: diff1-trunk.patch
>
>
> In the install script of the management-pack we do everything using shell
> calls. Instead we should use Ambari's python libraries.
> Example:
> {code}shell.call('sudo -u hdfs hadoop fs -mkdir -p /share'){code}
> As reference you can use the scripts of HDFS:
> [https://github.com/apache/ambari/tree/trunk/ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts]
> which make good use of Ambari libraries. Microsoft-R scripts should use just
> like these.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
