[
https://issues.apache.org/jira/browse/AMBARI-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333800#comment-15333800
]
Hadoop QA commented on AMBARI-17146:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12810850/AMBARI-17146_5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.state.ServiceComponentTest
org.apache.ambari.server.controller.internal.ConfigGroupResourceProviderTest
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7371//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7371//console
This message is automatically generated.
> Implement config values trimming for deployment via blueprint
> -------------------------------------------------------------
>
> Key: AMBARI-17146
> URL: https://issues.apache.org/jira/browse/AMBARI-17146
> Project: Ambari
> Issue Type: Task
> Affects Versions: 2.4.0
> Reporter: Dmytro Sen
> Assignee: Dmytro Sen
> Priority: Critical
> Fix For: 2.4.0
>
> Attachments: AMBARI-17146_4.patch, AMBARI-17146_5.patch
>
>
> Implement config values trimming for deployment via blueprint as we do in UI
> {code}
> trimProperty: function (property) {
> var displayType = Em.get(property, 'displayType');
> var value = Em.get(property, 'value');
> var name = Em.get(property, 'name');
> var rez;
> switch (displayType) {
> case 'directories':
> case 'directory':
> rez = value.replace(/,/g, ' ').trim().split(/\s+/g).join(',');
> break;
> case 'host':
> rez = value.trim();
> break;
> case 'password':
> break;
> default:
> if (name == 'javax.jdo.option.ConnectionURL' || name ==
> 'oozie.service.JPAService.jdbc.url') {
> rez = value.trim();
> }
> rez = (typeof value == 'string') ? value.replace(/(\s+$)/g, '') :
> value;
> }
> return ((rez == '') || (rez == undefined)) ? value : rez;
> },
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
