[
https://issues.apache.org/jira/browse/AMBARI-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347382#comment-15347382
]
Hadoop QA commented on AMBARI-17382:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12812953/AMBARI-17382.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-metrics/ambari-metrics-timelineservice:
org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.discovery.TestMetadataManager
org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.availability.MetricCollectorHAControllerTest
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7521//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7521//console
This message is automatically generated.
> Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint
> -------------------------------------------------------------------------
>
> Key: AMBARI-17382
> URL: https://issues.apache.org/jira/browse/AMBARI-17382
> Project: Ambari
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Critical
> Labels: ambari-metrics
> Fix For: 2.4.0
>
> Attachments: AMBARI-17382.patch
>
>
> With PHOENIX-914, there is a change in implementation , As earlier, timestamp
> range was passed as a hint to the query to get advantage of native timerange
> optimization in hbase but with new implementation we can mark the timestamp
> column in the schema as a ROW_TIMESTAMP and pass timestamp range with “where”
> clause only to achieve equivalent performance and better accuracy.
> For eq:-
> With earlier implementation , AMS forms query like this:-
> SELECT /*+ NATIVE_TIME_RANGE(1448029523000) */ METRIC_NAME, APP_ID,
> INSTANCE_ID, SERVER_TIME, UNITS, METRIC_SUM, HOSTS_COUNT, METRIC_MAX,
> METRIC_MIN FROM METRIC_AGGREGATE WHERE (METRIC_NAME IN
> ('regionserver.Server.totalRequestCount',
> 'regionserver.Server.blockCacheCountHitPercent',
> 'regionserver.Server.regionCount',
> 'regionserver.Server.compactionQueueLength',
> 'regionserver.Server.storeFileCount', 'master.Server.averageLoad')) AND
> APP_ID = 'ams-hbase' AND SERVER_TIME >= 1448029643000 AND SERVER_TIME <
> 1448033243 ORDER BY METRIC_NAME, SERVER_TIME LIMIT 11520
> But with PHOENIX-914 :-
> Declare SERVER_TIME as ROW_TIMESTAMP in schema:-
> CREATE TABLE DESTINATION_METRICS_TABLE (SERVER_TIME DATE not null, METRIC_ID
> CHAR(15) not null, METRIC_VALUE bigint … CONSTRAINT PK PRIMARY
> KEY(CREATED_DATE ROW_TIMESTAMP, METRIC_ID…)) …;
> And remove hint from the query:-
> SELECT METRIC_NAME, APP_ID, INSTANCE_ID, SERVER_TIME, UNITS, METRIC_SUM,
> HOSTS_COUNT, METRIC_MAX, METRIC_MIN FROM METRIC_AGGREGATE WHERE (METRIC_NAME
> IN ('regionserver.Server.totalRequestCount',
> 'regionserver.Server.blockCacheCountHitPercent',
> 'regionserver.Server.regionCount',
> 'regionserver.Server.compactionQueueLength',
> 'regionserver.Server.storeFileCount', 'master.Server.averageLoad')) AND
> APP_ID = 'ams-hbase' AND SERVER_TIME >= 1448029643000 AND SERVER_TIME <
> 1448033243 ORDER BY METRIC_NAME, SERVER_TIME LIMIT 11520
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
