[
https://issues.apache.org/jira/browse/AMBARI-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523296#comment-15523296
]
Hadoop QA commented on AMBARI-18464:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12830333/AMBARI-18464.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/8713//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8713//console
This message is automatically generated.
> Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues
> ---------------------------------------------------------------------
>
> Key: AMBARI-18464
> URL: https://issues.apache.org/jira/browse/AMBARI-18464
> Project: Ambari
> Issue Type: Bug
> Reporter: Andrew Onischuk
> Assignee: Andrew Onischuk
> Fix For: 3.0.0
>
> Attachments: AMBARI-18464.patch
>
>
> Python's `Popen` constructor takes an optional argument called `close_fds`
> which instructs Python to close all open file descriptors except for pipe,
> stdout, and stderr. However, Python's logic chooses to iterate over all
> possible open handles, not just those which are actually open.
> * With my `ulimit -n 1024`, `Popen` was taking ~2ms
> * With my `ulimit -n 1000000`, `Popen` was taking ~150ms
> That's an increase of 7400%, and all I did was increase my ulimit. The number
> of FDs opened was consistent.
> In some environments, this `Popen` call can take between 6 and 60 seconds per
> call. This leads to a problem where status commands cannot be drained fast
> enough and results in the agent not responding to heartbeats and not running
> commands.
> This Jira serves two purposes:
> * Investigate our use of `close_fds` and determine if it's correct (or at
> least needs to be parameterized as a configuration option.
> * Provide a host check warning for the ulimit being too high.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
