[
https://issues.apache.org/jira/browse/AMBARI-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687070#comment-15687070
]
Hadoop QA commented on AMBARI-18949:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840033/AMBARI-18949-Quicklinks-properties-trunk-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.state.ServicePropertiesTest
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/9355//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/9355//console
This message is automatically generated.
> Extend current quick link JSON with properties
> ----------------------------------------------
>
> Key: AMBARI-18949
> URL: https://issues.apache.org/jira/browse/AMBARI-18949
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Affects Versions: 2.5.0
> Reporter: Balázs Bence Sári
> Assignee: Balázs Bence Sári
> Fix For: 2.5.0
>
> Attachments: AMBARI-18949-Quicklinks-properties-trunk-v2.patch
>
>
> Quick link data json should have an optional _properties_ field for each
> link. This field is a list of Strings and can contain informative tags about
> the quicklink such a _sso_ or _authenticated_.
> New json parser should be compatible with legacy quick links not having this
> field.
> *Example (change highlighted)*
> {code:javascript}
> ...
> "links": [
> {
> "name": "ranger_admin_ui",
> "label": "Ranger Admin UI",
> "requires_user_name": "false",
> "url": "%@://%@:%@",
> --> "properties": ["sso", "authenticated"], <--
> "port":{
> "http_property": "ranger.service.http.port",
> "http_default_port": "6080",
> "https_property": "ranger.service.https.port",
> "https_default_port": "6182",
> "regex": "(\\d*)+",
> "site": "ranger-admin-site"
> }
> }
> ]
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
