[ 
https://issues.apache.org/jira/browse/AMBARI-18929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695938#comment-15695938
 ] 

Di Li commented on AMBARI-18929:
--------------------------------

Hello Wei Wei

1. 
"if active_rm_webapp_address is None:
     raise Fail('Resource Manager state is not available, {0} cannot be 
accessed'.format(','.join(rm_webapp_addresses)));"
Can you change it to
     "Resource Manager state is not available. Failed to determine the active 
Resource Manager web application address from {0}"....

2.
Could you fix the Python unit test errors?  You can run the specific Python 
unit test suite locally on your env with the following command. Run it under 
the ambari root dir:  mvn -pl ambari-server -DskipSurefireTests 
-Dpython.test.mask=test_yarn_service_check.py clean test

{noformat}
-1 core tests. The test build failed in ambari-server
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/9400//testReport/
{noformat}

Details on the test failures is in 
https://builds.apache.org/job/Ambari-trunk-test-patch/9400//artifact/patch-work/testrun_ambari-server.txt

{noformat}
Failed tests:
ERROR: test_service_check_default (test_yarn_service_check.TestServiceCheck)
----------------------------------------------------------------------
Traceback (most recent call last):
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
 line 1199, in patched
    return func(*args, **keywargs)
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py",
 line 47, in test_service_check_default
    checked_call_mocks = [(0, "some test text, appTrackingUrl=http:"
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 155, in executeScript
    method(RMFTestCase.env, *command_args)
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py",
 line 153, in service_check
    if active_rm_webapp_address is None:
UnboundLocalError: local variable 'active_rm_webapp_address' referenced before 
assignment
 
ERROR: test_service_check_secured (test_yarn_service_check.TestServiceCheck)
----------------------------------------------------------------------
Traceback (most recent call last):
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
 line 1199, in patched
    return func(*args, **keywargs)
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py",
 line 80, in test_service_check_secured
    checked_call_mocks = [(0, "some test text, appTrackingUrl=http:"
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 155, in executeScript
    method(RMFTestCase.env, *command_args)
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py",
 line 153, in service_check
    if active_rm_webapp_address is None:
UnboundLocalError: local variable 'active_rm_webapp_address' referenced before 
assignment
{noformat}
3. Update the patch on this JIRA
  a) Click Cancel Patch, the "Patch Available" label should disappear
  b) Regenerate and Upload the new patch
  c) Click  Submit Patch to have Hadoop QA ( a robot) to test it again

4. If Hadoop QA gives an overall +1 for #3, then submit a review request on the 
Review Board: https://reviews.apache.org/dashboard/

Let me know if you don't know how to submit reviews on the Review Board I can 
help you out on that as well.

> Yarn service check fails when either resource manager is down in HA enabled 
> cluster
> -----------------------------------------------------------------------------------
>
>                 Key: AMBARI-18929
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18929
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Weiwei Yang
>         Attachments: AMBARI-18929_trunk.patch
>
>
> When HA is enabled, yarn service_check.py fails if one of RM is down, even 
> the other one is active. This gives user the wrong impression the yarn 
> cluster is not healthy. Instead, service check should pass, or at least pass 
> with warning that lets user know there is one RM down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to