[
https://issues.apache.org/jira/browse/AMBARI-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709214#comment-15709214
]
Di Li commented on AMBARI-18962:
--------------------------------
All Failed Tests
Test Name
Duration
Age
org.apache.ambari.server.upgrade.UpgradeCatalog250Test.testExecuteDMLUpdates
This is not related to the Python script code change introduced via this JIRA.
> Make check_package_condition in script.py overridable by services in stacks
> ---------------------------------------------------------------------------
>
> Key: AMBARI-18962
> URL: https://issues.apache.org/jira/browse/AMBARI-18962
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: trunk, 2.5.0
> Reporter: Di Li
> Assignee: Di Li
> Fix For: trunk, 2.5.0
>
> Attachments: AMBARI-18962.patch
>
>
> check_package_condition method in script.py was added via AMBARI-14739 to
> make the conditionally installing RPMs controlled jointly by metainfo.xml and
> functions defined in package_conditions.py. For example, with the following
> metainfo.xml section. The package_conditions.py has the
> should_install_ams_collector function implementation.
> <package>
> <name>ambari-metrics-collector</name>
> <skipUpgrade>true</skipUpgrade>
> <condition>should_install_ams_collector</condition>
> </package>
> The issue is that this is not easily extendable by services extensions
> (installed via mpack), as any third party service needs to add functions to
> package_conditions.py in resource_management library.
> This JIRA proposes to make check_package_condition overwritable at the
> service level ( by changing it from a static method to a instance method).
> Then each service can still maintain the metainfo.xml section, while
> implement its own check_package_condition that pulls in its own
> package_condition util.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
