[
https://issues.apache.org/jira/browse/AMBARI-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748807#comment-15748807
]
Hadoop QA commented on AMBARI-19164:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12843228/AMBARI-19164.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.controller.metrics.JMXPropertyProviderTest
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/9666//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/9666//console
This message is automatically generated.
> Add PK to hostcomponentdesiredstate Table To Support FK Relationships
> ---------------------------------------------------------------------
>
> Key: AMBARI-19164
> URL: https://issues.apache.org/jira/browse/AMBARI-19164
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Reporter: Sebastian Toader
> Assignee: Sebastian Toader
> Priority: Critical
> Fix For: 2.5.0
>
> Attachments: AMBARI-19164.v1.patch
>
>
> The {{hostcomponentdesiredstate}} table currently uses a compound PK based
> off of the cluster ID, service name, host id and component name. There are
> several problems with this approach:
> * Primary Keys should be data that's not part of the business logic of the
> system and not subject to be changed potentially (as strings are).
> * Other tables referencing the {{hostcomponentdesiredstate}} table would now
> need knowledge of cluster/service/component/host in order to make the correct
> FK association. This leads to extra data being tracked as well as data
> duplication.
> * Some databases, such as SQL Server, have problems with the indexing of
> compound PKs and may lead to deadlocks when querying and updating
> concurrently.
> This table needs to be changed so that it uses a simple PK for referencing.
> FK relationships as they exist today can still be maintained as long as a
> {{UNIQUE}} constraint is placed on the table. We should:
> * Add a {{UNIQUE}} constraint to the former PK columns
> * Add an {{INDEX}} to the former PK columns
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
