[
https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755299#comment-15755299
]
Hudson commented on AMBARI-19149:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #6249 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/6249/])
AMBARI-19149. Code cleanup: compiler warnings (Attila Doroszlai via (ncole:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=edce0b1173b6629e50b053be140490fa288ec361])
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelperTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/ContainsPredicateTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/Parallel.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/UtilsTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalServiceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachineFactory.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/collections/PredicateUtils.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/SimplifyingPredicateVisitorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceFunctionalTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewURLResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerAction.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseServiceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/utils/SetUtilsTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/InOperator.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/HostGroupInfoTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDataMigrationContextImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionResponse.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/stack/RepoUtilTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/QueryCreateHandlerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/EqualsPredicateTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java
* (edit) ambari-server/pom.xml
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java
> Clean up Ambari Server source code warnings
> -------------------------------------------
>
> Key: AMBARI-19149
> URL: https://issues.apache.org/jira/browse/AMBARI-19149
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-19149-1.patch, AMBARI-19149-3.patch,
> AMBARI-19149-4.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly
> over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes
> changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a
> nightmare. We need to go through and clean out as many of these warnings as
> possible.
> Note: With respect to the import cleanup, the IDE of choice should have the
> following import order setup. They should always be expanded and never use
> {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
