[ 
https://issues.apache.org/jira/browse/AMBARI-19372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800931#comment-15800931
 ] 

Doroszlai, Attila commented on AMBARI-19372:
--------------------------------------------

The failed test is unrelated:

{noformat}
FAIL: test_execute_retryable_command_with_time_lapse 
(TestActionQueue.TestActionQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
 line 1199, in patched
    return func(*args, **keywargs)
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-agent/src/test/python/ambari_agent/TestActionQueue.py",
 line 1199, in test_execute_retryable_command_with_time_lapse
    self.assertEqual(1, sleep_mock.call_count)
AssertionError: 1 != 2986

----------------------------------------------------------------------
Ran 452 tests in 15.782s

FAILED (failures=1)
{noformat}

{{FileCache}} tests were OK:

{noformat}
test_build_download_url (TestFileCache.TestFileCache) ... ok
test_fetch_url (TestFileCache.TestFileCache) ... ok
test_get_custom_actions_base_dir (TestFileCache.TestFileCache) ... ok
test_get_custom_resources_subdir (TestFileCache.TestFileCache) ... ok
test_get_hook_base_dir (TestFileCache.TestFileCache) ... ok
test_get_service_base_dir (TestFileCache.TestFileCache) ... ok
test_invalidate_directory (TestFileCache.TestFileCache) ... ok
test_provide_directory (TestFileCache.TestFileCache) ... ok
test_provide_directory_no_update (TestFileCache.TestFileCache) ... ok
test_read_write_hash_sum (TestFileCache.TestFileCache) ... ok
test_reset (TestFileCache.TestFileCache) ... ok
test_unpack_archive (TestFileCache.TestFileCache) ... ok
test_update_disabled_for_parallel_execution (TestFileCache.TestFileCache) ... ok
test_update_disabled_for_server_setting (TestFileCache.TestFileCache) ... ok
test_update_enabled_by_default (TestFileCache.TestFileCache) ... ok
{noformat}

> Disable FileCache update for parallel_execution
> -----------------------------------------------
>
>                 Key: AMBARI-19372
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19372
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-agent
>    Affects Versions: 3.0.0
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19372.patch
>
>
> Ambari agent's {{FileCache}} is not thread-safe, hence needs to be disabled 
> if {{parallel_execution}} is enabled.  The server's 
> {{agent.auto.cache.update=false}} setting is not enough to prevent all 
> subprocesses from using the file cache, because they are started before the 
> setting is received from the server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to