[
https://issues.apache.org/jira/browse/AMBARI-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alejandro Fernandez updated AMBARI-19395:
-----------------------------------------
Description:
Unit tests on Apache are failing because the checkstyle rules are too strict,
especially when it comes to imports.
Right now, it requires this, which I want to remove because it means that
everyone has to use an IDE and setup the same rules for something that is
trivial at compile-time and actually causes more headaches for developers.
{code}
<module name="ImportOrder">
<property name="groups" value="java,javax,org,com,*"/>
<property name="ordered" value="true"/>
<property name="separated" value="true"/>
<property name="option" value="top"/> <!-- static imports -->
<property name="sortStaticImportsAlphabetically" value="true"/>
</module>
{code}
{noformat}
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
[ERROR]
/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java:34:8:
Unused import - com.sun.security.auth.callback.TextCallbackHandler.
[UnusedImports]
[ERROR]
/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java:41:
Wrong order for 'org.easymock.EasyMockSupport' import. [ImportOrder]
{noformat}
was:
Unit tests on Apache are failing because the checkstyle rules are too strict,
especially when it comes to imports.
Right now, it requires this, which I want to remove because it means that
everyone has to use an IDE and setup the same rules for something that is
trivial at compile-time and actually causes more headaches for developers.
{code}
<module name="ImportOrder">
<property name="groups" value="java,javax,org,com,*"/>
<property name="ordered" value="true"/>
<property name="separated" value="true"/>
<property name="option" value="top"/> <!-- static imports -->
<property name="sortStaticImportsAlphabetically" value="true"/>
</module>
{code}
> Relax checkstyle rules since causing unit test failures
> -------------------------------------------------------
>
> Key: AMBARI-19395
> URL: https://issues.apache.org/jira/browse/AMBARI-19395
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: trunk
> Reporter: Alejandro Fernandez
> Assignee: Alejandro Fernandez
> Fix For: trunk
>
> Attachments: AMBARI-19395.patch
>
>
> Unit tests on Apache are failing because the checkstyle rules are too strict,
> especially when it comes to imports.
> Right now, it requires this, which I want to remove because it means that
> everyone has to use an IDE and setup the same rules for something that is
> trivial at compile-time and actually causes more headaches for developers.
> {code}
> <module name="ImportOrder">
> <property name="groups" value="java,javax,org,com,*"/>
> <property name="ordered" value="true"/>
> <property name="separated" value="true"/>
> <property name="option" value="top"/> <!-- static imports -->
> <property name="sortStaticImportsAlphabetically" value="true"/>
> </module>
> {code}
> {noformat}
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> [ERROR]
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java:34:8:
> Unused import - com.sun.security.auth.callback.TextCallbackHandler.
> [UnusedImports]
> [ERROR]
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java:41:
> Wrong order for 'org.easymock.EasyMockSupport' import. [ImportOrder]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
