[
https://issues.apache.org/jira/browse/AMBARI-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803384#comment-15803384
]
Hadoop QA commented on AMBARI-19395:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12845908/AMBARI-19395.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-admin ambari-server ambari-views utility.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/9931//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/9931//console
This message is automatically generated.
> Relax checkstyle rules since causing unit test failures
> -------------------------------------------------------
>
> Key: AMBARI-19395
> URL: https://issues.apache.org/jira/browse/AMBARI-19395
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: trunk
> Reporter: Alejandro Fernandez
> Assignee: Alejandro Fernandez
> Fix For: trunk
>
> Attachments: AMBARI-19395.patch
>
>
> Unit tests on Apache are failing because the checkstyle rules are too strict,
> especially when it comes to imports.
> Right now, it requires this, which I want to remove because it means that
> everyone has to use an IDE and setup the same rules for something that is
> trivial at compile-time and actually causes more headaches for developers.
> {code}
> <module name="ImportOrder">
> <property name="groups" value="java,javax,org,com,*"/>
> <property name="ordered" value="true"/>
> <property name="separated" value="true"/>
> <property name="option" value="top"/> <!-- static imports -->
> <property name="sortStaticImportsAlphabetically" value="true"/>
> </module>
> {code}
> {noformat}
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> [ERROR]
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java:34:8:
> Unused import - com.sun.security.auth.callback.TextCallbackHandler.
> [UnusedImports]
> [ERROR]
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java:41:
> Wrong order for 'org.easymock.EasyMockSupport' import. [ImportOrder]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
