[ 
https://issues.apache.org/jira/browse/AMBARI-19590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826388#comment-15826388
 ] 

Hadoop QA commented on AMBARI-19590:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12847856/AMBARI-19590_trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-web.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10092//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10092//console

This message is automatically generated.

> Add/delete host component: visual changes for configuration popup
> -----------------------------------------------------------------
>
>                 Key: AMBARI-19590
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19590
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-web
>    Affects Versions: 2.5.0
>            Reporter: Andrii Babiichuk
>            Assignee: Andrii Babiichuk
>            Priority: Critical
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-19590_trunk.patch
>
>
> - Information div similar to "Recommended Changes" one should be added for 
> "Required Changes" as well. This should say "The following configuration 
> changes are required and will be applied automatically."
> - There's not enough spacing between confirnation message and the information 
> div itself.
> - The information div for recommended changes should come after the header 
> "Recommended Changes".  Similarly, the information div for required changes 
> should come after the header "Required Changes".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to