[
https://issues.apache.org/jira/browse/AMBARI-19574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827208#comment-15827208
]
Hudson commented on AMBARI-19574:
---------------------------------
FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #6472 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/6472/])
AMBARI-19574 - Add upgrade logic for the heap dump control option added
(jhurley:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=410f2943d5babf6b9bd3e2f225fbbe9ac5761ee2])
* (edit)
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
* (edit)
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml
* (edit) ambari-server/src/main/resources/upgrade-config.xsd
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
* (edit)
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
> Add upgrade logic for the heap dump control option added in HDP 2.6 stack.
> --------------------------------------------------------------------------
>
> Key: AMBARI-19574
> URL: https://issues.apache.org/jira/browse/AMBARI-19574
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.5.0
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Critical
> Fix For: 2.5.0
>
> Attachments: AMBARI-19574.patch
>
>
> Looking at https://reviews.apache.org/r/54527, some properties were added for
> Hive and Hive2 which need to be included in the upgrade from HDP 2.5 to HDP
> 2.6.
> - It looks like the following properties were added to HDP 2.6 only. They
> will automatically be merged in on stack upgrades from HDP 2.5, so there's no
> work to be done there. The following will be automatically merged in since
> they are completely new:
> -- {{hive-env/enable_heap_dump}}
> -- {{hive-env/heap_dump_location}}
> -- {{tez-env/enable_heap_dump}}
> -- {{tez-env/heap_dump_location}}
> - Since Ambari 2.4 doesn't support HDP 2.6, that means we don't need to worry
> about HDP 2.6 to HDP 2.6 at all (where we would need to add the above
> properties manually).
> - Now the interesting part. The following properties are _NOT_ new. They
> existed in prior stacks, which means that they will be automatically merged
> only if they have not changed their default values on the prior stack:
> -- {{tez-site/tez.task.launch.cmd-opts}}
> -- {{hive-env/content}}
> -- {{hive-interactive-env/llap_java_opts}}
> -- {{hive-interactive-env/content}}
> So, what do we do with them?
> - {{tez-site/tez.task.launch.cmd-opts}} and
> {{hive-interactive-env/llap_java_opts}} don't seem too bad since it looks
> like the main difference is a token. We can do a find/replace for this:
> -- {code:title=tez-site}
> Replace: -XX:+UseParallelGC
> with
> XX:+UseParallelGC{{heap_dump_opts}}
> {code}
> -- {code:title=hive-interactive-env/llap_java_opts}
> Replace -XX:+UseParallelGC{% endif %}
> with
> XX:+UseParallelGC{% endif %}{{heap_dump_opts}}
> {code}
> However the {{content}} properties are much harder to work with, as customers
> change them all the time. This is where we need something more flexible than
> replace - something like an insert.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
