[
https://issues.apache.org/jira/browse/AMBARI-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834287#comment-15834287
]
Hadoop QA commented on AMBARI-19662:
------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12848872/AMBARI-19662-strict-filter-definitions_trunk_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/10194//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/10194//console
This message is automatically generated.
> Unknown attributes should not be allowed in quick link filter definitions
> -------------------------------------------------------------------------
>
> Key: AMBARI-19662
> URL: https://issues.apache.org/jira/browse/AMBARI-19662
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: trunk, 2.5.0
> Reporter: Balázs Bence Sári
> Assignee: Balázs Bence Sári
> Fix For: trunk, 2.5.0
>
> Attachments: AMBARI-19662-strict-filter-definitions_trunk_v2.patch
>
>
> When the user makes a syntax error in a quick link definition, such as:
> {code}
> { "linKKK_name": "namenode_ui", "visible": true }
> {code}
> the filter will be misinterpreted as an accept-all filter, due to the fact
> that the parser would expect a proper "link_name" tag to interpret it as a
> link name filter. This would lead to unexpected and difficult to debug
> behaviour.
> To prevent this, quick link profile evaluation should throw an exception
> whenever it finds unknown tags in a filter definition
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
