[
https://issues.apache.org/jira/browse/AMBARI-19681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836542#comment-15836542
]
Hadoop QA commented on AMBARI-19681:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12849145/rb55853.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-agent.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/10230//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/10230//console
This message is automatically generated.
> Credential Store should add hadoop credential provider path property to all
> affected configuration types
> --------------------------------------------------------------------------------------------------------
>
> Key: AMBARI-19681
> URL: https://issues.apache.org/jira/browse/AMBARI-19681
> Project: Ambari
> Issue Type: Bug
> Components: ambari-agent
> Affects Versions: 2.5.0
> Reporter: Nahappan Somasundaram
> Assignee: Nahappan Somasundaram
> Fix For: 2.5.0
>
> Attachments: rb55853.patch
>
>
> CustomServiceOrchestrator.py function generateJceks adds the property
> 'hadoop.security.credential.provider.path' only to the last configuration
> type that requires it. The function iterates over the configtype_credentials
> dictionary, and at each iteration it updates the variable named config (line
> 272):
> {code}
> config = commandJson['configurations'][config_type]
> {code}
> After the iteration is over, and the provider_paths variable is set the
> function adds the provider paths to the dictionary with the key
> 'hadoop.security.credential.provider.path' (line 292)
> {code}
> config[self.CREDENTIAL_PROVIDER_PROPERTY_NAME] = ','.join(provider_paths)
> {code}
> The problem is that at this point the variable config contains the latest
> config type that needs this property to be set up, while all of them should
> have it! So if both config_type_1, and config_type_2 have passwords
> properties present in configtype_credentials, only config_type_2 will have
> the dictionary entry set for the key
> 'hadoop.security.credential.provider.path', and it will contain a reference
> to both of their jceks files!
> Another issue is that there is no reason to collect the provider paths to an
> array, each config_type should have a reference only to it's own provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
