[ 
https://issues.apache.org/jira/browse/AMBARI-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880657#comment-15880657
 ] 

Hadoop QA commented on AMBARI-20136:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12854153/AMBARI-20136.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10706//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10706//console

This message is automatically generated.

> Services should be able to specify that credential store is always enabled
> --------------------------------------------------------------------------
>
>                 Key: AMBARI-20136
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20136
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.5.0
>            Reporter: Sumit Mohanty
>            Assignee: Sumit Mohanty
>            Priority: Critical
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-20136.patch
>
>
> At this point, credential store can be enabled or disabled for a service. 
> Some services, such as Ranger and LogSearch should be able to indicate that 
> CS cannot be disabled. The eventual goal is to always have CS enabled for all 
> services that support credential store.
> Current metainfo.xml has the following section
> {code}
>       <credential-store>
>         <supported>true</supported>
>         <enabled>false</enabled>
>       </credential-store>
> {code}
> We need to add a notion of required. A third element called "required" may be 
> added. We can potentially, create an enum for a new field "supportType" and 
> collapse "supported" and "required" but that, while succinct, does not help 
> much in readability.
> {code}
>       <credential-store>
>         <supported>true</supported>
>         <required>false</required>
>         <enabled>false</enabled>
>       </credential-store>
> {code}
> The above means, CS is supported, not required, and not enabled. "false" is 
> the default for *required*.
> For services that require CS support
> {code}
>       <credential-store>
>         <supported>true</supported>
>         <required>true</required>
>         <enabled>true</enabled>
>       </credential-store>
> {code}
> Service create logic should set the CS-enabled flag to be true if *required* 
> is true independent of what *enabled* says. *required* flag is not needed in 
> the service resource REST API but the stacks API should provide access to 
> this flag.
> API to disable CS should throw an error if *required* is true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to