[
https://issues.apache.org/jira/browse/AMBARI-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955815#comment-15955815
]
Hadoop QA commented on AMBARI-20672:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12861921/AMBARI-20672.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.state.alerts.AlertStateChangedEventTest
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/11300//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11300//console
This message is automatically generated.
> Cluster Merge At End Of Upgrade Creation Cascades Unnecessarily
> ---------------------------------------------------------------
>
> Key: AMBARI-20672
> URL: https://issues.apache.org/jira/browse/AMBARI-20672
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.4.2
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Critical
> Fix For: 2.5.1
>
> Attachments: AMBARI-20672.patch
>
>
> During the creation of an upgrade, an association is made between the
> ClusterEntity and the UpgradeEntity so that determining if an upgrade is in
> progress can be fast.
> {code}
> upgradeEntity.setRequestId(request.getId());
> request.persist();
> s_upgradeDAO.create(upgradeEntity);
> cluster.setUpgradeEntity(upgradeEntity);
> {code}
> {code}
> public void setUpgradeEntity(UpgradeEntity upgradeEntity) throws
> AmbariException {
> try {
> ClusterEntity clusterEntity = getClusterEntity();
> clusterEntity.setUpgradeEntity(upgradeEntity);
> clusterDAO.merge(clusterEntity);
> ...
> {code}
> The problem here is that the merge is propagated to the UpgradeEntity via a
> {{CascadeType.ALL}} and it's not necessary. It seems like the only cascade
> should be {{CascadeType.REMOVE}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
