[
https://issues.apache.org/jira/browse/AMBARI-21185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042526#comment-16042526
]
Hudson commented on AMBARI-21185:
---------------------------------
FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7589 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7589/])
AMBARI-21185. False positive unused import for nested class referenced
(adoroszlai:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=2ff48a00b155a65ac0daa55ac8f8be00774b158f])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
> False positive unused import for nested class referenced only in Javadoc
> ------------------------------------------------------------------------
>
> Key: AMBARI-21185
> URL: https://issues.apache.org/jira/browse/AMBARI-21185
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 3.0.0
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-21185.patch
>
>
> Checkstyle reports unused import:
> {code}
> [ERROR]
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java:99:8:
> Unused import - org.apache.ambari.server.state.stack.upgrade.StageWrapper.
> [UnusedImports]
> Audit done.
> {code}
> However, StageWrapper is referenced in the JavaDoc. IDEs, like Eclipse, don't
> warn on this import since it's technically used int he JavaDoc generation:
> {code}
> /**
> * Tests that commands created for {@link StageWrapper.Type#RU_TASKS} set
> the
> * service and component on the {@link ExecutionCommand}.
> {code}
> This is an upstream bug: https://github.com/checkstyle/checkstyle/issues/3098
> and https://github.com/checkstyle/checkstyle/issues/3453.
> I think the best thing we can do here is {{@link}} by full classname in the
> JavaDoc and avoid the import. This way we avoid both Checkstyle error when
> import is present (due to "unused" import) and IDE warning when import is
> missing (due to unresolved class).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
