[
https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046449#comment-16046449
]
Hudson commented on AMBARI-19149:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #7611 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7611/])
AMBARI-19149. Code cleanup: concatenation in debug messages, unnecessary
(adoroszlai:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=219f22345e6f7b7ad38cdaac02e9bbe8c8ad7254])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionDirectory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsConfiguration.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateSign.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractJDBCResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateDownload.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/TopologyHostTask.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/AmbariPath.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/resources/api/rest/GetResource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StopGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AppCookieManager.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/security/encryption/MasterKeyServiceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaMetricTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/services/PersistServiceTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
* (edit) ambari-server/pom.xml
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyServiceImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ServiceCalculatedStateFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewDataMigrationService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapResourceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/security/SslExecutionTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/action/ActionImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/CertificateManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigUpgradePack.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilter.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionSchedulerImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/Register.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/credentialapi/CredentialUtil.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BootStrapImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/CommandUtils.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/LocalAgentSimulator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DatabaseMetricsSource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheSizeOfEngine.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariPerformanceMonitor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StartGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RestartGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
> Clean up Ambari Server source code warnings
> -------------------------------------------
>
> Key: AMBARI-19149
> URL: https://issues.apache.org/jira/browse/AMBARI-19149
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-19149-10.patch, AMBARI-19149-11.patch,
> AMBARI-19149-12.patch, AMBARI-19149-13.patch, AMBARI-19149-14.patch,
> AMBARI-19149-1.patch, AMBARI-19149-3.patch, AMBARI-19149-4.patch,
> AMBARI-19149-5.patch, AMBARI-19149-6.patch, AMBARI-19149-7.patch,
> AMBARI-19149-9.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly
> over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes
> changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a
> nightmare. We need to go through and clean out as many of these warnings as
> possible.
> Note: With respect to the import cleanup, the IDE of choice should have the
> following import order setup. They should always be expanded and never use
> {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
