[
https://issues.apache.org/jira/browse/AMBARI-21344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063158#comment-16063158
]
Hadoop QA commented on AMBARI-21344:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874506/AMBARI-21344.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 javac{color}. The patch appears to cause the [build to
fail|https://builds.apache.org/job/Ambari-trunk-test-patch/11679//artifact/patch-work/patchJavacWarnings.txt].
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11679//console
This message is automatically generated.
> Add Services Using Repository ID
> --------------------------------
>
> Key: AMBARI-21344
> URL: https://issues.apache.org/jira/browse/AMBARI-21344
> Project: Ambari
> Issue Type: Bug
> Components: ambari-web
> Affects Versions: 3.0.0
> Reporter: Antonenko Alexander
> Assignee: Antonenko Alexander
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: AMBARI-21344.patch
>
>
> Currently, the web client uses the repository version when adding services.
> Since multiple repositories from different vendors may have identical
> repository strings, we should switch to using the unique Repo ID instead of
> the version. Here's an example of the call being made today:
> {code:title=POST http://localhost:8080/api/v1/clusters/c1/services}
> [
> {
> "ServiceInfo": {
> "service_name": "ZOOKEEPER",
> "desired_repository_version": "2.6.0.0-334"
> }
> }
> ]
> {code}
> This should change to the following:
> {code:title=POST http://localhost:8080/api/v1/clusters/c1/services}
> [
> {
> "ServiceInfo": {
> "service_name": "ZOOKEEPER",
> "desired_repository_version_id": 1
> }
> }
> ]
> {code}
> The same change needs to be made for when a service is added to a cluster.
> However, this case it a bit trickier if there are multiple repositories.
> Until a more well-defined UX workflow is available, the following should be
> used for adding services:
> - If there is only a single repository, then use that one
> - If there are more than 1 repository, then choose the most recent repository
> -- It cannot be a {{PATCH}} repository
> -- Its status must be {{CURRENT}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
