[
https://issues.apache.org/jira/browse/AMBARI-21442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089484#comment-16089484
]
Hadoop QA commented on AMBARI-21442:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12877536/AMBARI-21442.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11797//console
This message is automatically generated.
> Ambari updates memory settings in blueprint incorrectly
> -------------------------------------------------------
>
> Key: AMBARI-21442
> URL: https://issues.apache.org/jira/browse/AMBARI-21442
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.2.2
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Fix For: 3.0.0
>
> Attachments: AMBARI-21442.patch
>
>
> Ambari appended a 'm' suffix to certain memory settings related properties
> during blueprint install. This was implemented in the MPropertyUpdater.
> For example if namenode_heapsize was 512 then Ambari updated it to 512m.
> However if the property already had a suffix like 4g then it was updated to
> be 4gm.
> This patch does 2 things differently
> 1. Instead of the hardcoded 'm' suffix, it uses the unit that is defined in
> the stack (if the stack doesn't define anything it falls back using 'm' as
> before).
> 2. It checks if the property already has some unit, and if that unit doesn't
> match the stack defined unit, then the blueprint will be rejected with an
> error (this case has never worked before)
> For examples:
> 1. 4g is rejected if the stack defined unit is MB.
> 2. 4 becomes 4m if the stack defined unit is MB.
> 3. 4m stays 4m if the stack defined unit is MB.
> MPropertyUpdated was replaced with UnitUpdater. But a new TopologyValidator
> was also introduced. The purpose of this is to catch invalid properties
> earlier.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
