[
https://issues.apache.org/jira/browse/AMBARI-21907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159567#comment-16159567
]
Hadoop QA commented on AMBARI-21907:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12885913/AMBARI-21907.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The test build failed in
[ambari-server|https://builds.apache.org/job/Ambari-trunk-test-patch/12161//artifact/patch-work/testrun_ambari-server.txt]
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12161//console
This message is automatically generated.
> Ambari can demand an invalid python class name (containing hyphens) for the
> service advisor
> -------------------------------------------------------------------------------------------
>
> Key: AMBARI-21907
> URL: https://issues.apache.org/jira/browse/AMBARI-21907
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.5.2
> Reporter: Diego Santesteban
> Assignee: Diego Santesteban
> Fix For: trunk, 2.5.3, 2.6.0
>
> Attachments: AMBARI-21907.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> The service advisor class name is created as 'stackName + versionString +
> serviceName + "ServiceAdvisor"'. When stackName, versionString or serviceName
> contains a hyphen, the class name that Ambari wants is not valid in python.
> Ambari should remove hyphens from the service advisor class name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
