[
https://issues.apache.org/jira/browse/AMBARI-21921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161416#comment-16161416
]
Hadoop QA commented on AMBARI-21921:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886329/AMBARI-21921.0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The test build failed in
[ambari-server|https://builds.apache.org/job/Ambari-trunk-test-patch/12174//artifact/patch-work/testrun_ambari-server.txt]
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12174//console
This message is automatically generated.
> A print_warning_msg() in serverConfiguration.py has too few arguments.
> ----------------------------------------------------------------------
>
> Key: AMBARI-21921
> URL: https://issues.apache.org/jira/browse/AMBARI-21921
> Project: Ambari
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Masahiro Tanaka
> Assignee: Masahiro Tanaka
> Priority: Minor
> Attachments: AMBARI-21921.0.patch
>
>
> {{update_database_name_property}} function which is in
> {{serverConfiguration.py}} uses {{print_warning_msg}} to show a warning when
> {{check_database_name_property}} throws {{FatalException}}.
> {code}
> except FatalException:
> properties = get_ambari_properties()
> if properties == -1:
> err = "Error getting ambari properties"
> raise FatalException(-1, err)
> print_warning_msg("{0} property isn't set in {1} . Setting it to default
> value - {3}".format(JD
> BC_DATABASE_NAME_PROPERTY, AMBARI_PROPERTIES_FILE,
> configDefaults.DEFAULT_DB_NAME))
> properties.process_pair(JDBC_DATABASE_NAME_PROPERTY,
> configDefaults.DEFAULT_DB_NAME)
> conf_file = find_properties_file()
> {code}
> The argument should be use {code}{0}, {1}, {2}{code}, not {code}{0}, {1},
> {3}{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
