[
https://issues.apache.org/jira/browse/AMBARI-22104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187707#comment-16187707
]
Hadoop QA commented on AMBARI-22104:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889879/AMBARI-22104.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
org.apache.ambari.server.serveraction.upgrades.FixYarnWebServiceUrlTest
org.apache.ambari.server.serveraction.upgrades.FixCapacitySchedulerOrderingPolicyTest
org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest
org.apache.ambari.server.serveraction.upgrades.HiveEnvClasspathActionTest
org.apache.ambari.server.serveraction.upgrades.FixOozieAdminUsersTest
org.apache.ambari.server.serveraction.upgrades.UpgradeUserKerberosDescriptorTest
org.apache.ambari.server.serveraction.upgrades.HBaseEnvMaxDirectMemorySizeActionTest
org.apache.ambari.server.serveraction.upgrades.RangerConfigCalculationTest
org.apache.ambari.server.serveraction.upgrades.RangerUsersyncConfigCalculationTest
org.apache.ambari.server.state.ServicePropertiesTest
org.apache.ambari.server.serveraction.upgrades.SparkShufflePropertyConfigTest
org.apache.ambari.server.serveraction.upgrades.HiveZKQuorumConfigActionTest
org.apache.ambari.server.serveraction.upgrades.KerberosKeytabsActionTest
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12394//console
This message is automatically generated.
> Refactor existing server side actions to use the common
> AbstractUpgradeServerAction
> -----------------------------------------------------------------------------------
>
> Key: AMBARI-22104
> URL: https://issues.apache.org/jira/browse/AMBARI-22104
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Dmitry Lysnichenko
> Assignee: Dmitry Lysnichenko
> Attachments: AMBARI-22104.patch
>
>
> Other server-side classes need to use the abstract class in the summary.
> Identify fields that are largely common with the server-side actions and put
> them in the abstract class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
