[
https://issues.apache.org/jira/browse/AMBARI-22136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192071#comment-16192071
]
Hadoop QA commented on AMBARI-22136:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12890417/AMBARI-22136.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12434//console
This message is automatically generated.
> Enable server_action tasks defined in EU/RU upgrade pack xml files to take
> parameters
> -------------------------------------------------------------------------------------
>
> Key: AMBARI-22136
> URL: https://issues.apache.org/jira/browse/AMBARI-22136
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: trunk
> Reporter: Di Li
> Assignee: Di Li
> Fix For: trunk
>
> Attachments: AMBARI-22136.patch
>
>
> xsi:type="server_action" tasks defined in EU/RU upgrade pack xml files
> currently can only take impClass name, message, scope and summary as
> parameters. Since no custom parameters can pass in, each server_action is
> basically a special case where all stack/service information must be
> hardcoded in the Java logic.
> This JIRA proposes a way to pass in custom parameters as shown below
> (multiple "parameter" elements). This will allow developers to create general
> cased server_action that behaves accordingly to parameters passed in.
> <task xsi:type="server_action"
> class="org.apache.ambari.server.serveraction.upgrades.VerifyExtensionLinkAction">
> <parameter name='a'>a</parameter>
> <parameter name='b'>b</parameter>
> <parameter name='target_stack'>MyStack</parameter>
> <parameter name='target_stack_version'>1.2</parameter>
> </task>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
