[ 
https://issues.apache.org/jira/browse/AMBARI-21955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214683#comment-16214683
 ] 

Sanket Shah commented on AMBARI-21955:
--------------------------------------

[~u39kun] [~swapanshridhar]
Was the patch applied properly or was there any errors while doing so? 
The 
[commit|https://github.com/apache/ambari/commit/0c188aeae7343c76c2c0471c0b271237d0995d09]
 seems to have some changes that shouldn't be there. I have deleted multiple 
folders including "libs" but commit shows few files were left which was 
supposed to be moved to other directories. Even the changes you made for rat 
check wasn't needed since that directory was also supposed to be deleted.

Except that, even on latest trunk right now, I am properly able to apply my 
patch attached here (as well as one in review request). Could any of you guys 
try applying again and verify, please. Thanks in advance.

> Update React version to 15.6.2 to get MIT license
> -------------------------------------------------
>
>                 Key: AMBARI-21955
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21955
>             Project: Ambari
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Sanket Shah
>            Assignee: Sanket Shah
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-21955.patch, storm-monitoring-build-error-2.6.txt
>
>
> The Apache Software Foundation Legal Affairs Committee [has announced | 
> https://issues.apache.org/jira/browse/LEGAL-303?focusedCommentId=16088663&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16088663]that
>  the so-called 'Facebook BSD+Patents License' is no longer allowed to be used 
> as a direct dependency in Apache projects.
> Since Storm View is using React.js which is under the same Facebook's 
> license, needs to get rid of and use Vue.js instead.
> cc: [~ggolani]
> Update: No need to port to Vue, instead update the version to get MIT license.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to