[
https://issues.apache.org/jira/browse/AMBARI-22353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236098#comment-16236098
]
Hadoop QA commented on AMBARI-22353:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12895427/AMBARI-22353.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
ambari-server:
org.apache.ambari.server.api.query.render.MinimalRendererTest
org.apache.ambari.server.api.TestSuite
org.apache.ambari.server.controller.internal.RequestImplTest
org.apache.ambari.server.controller.internal.RequestResourceProviderTest
org.apache.ambari.server.controller.internal.AbstractResourceProviderTest
org.apache.ambari.server.controller.internal.HostComponentResourceProviderTest
org.apache.ambari.server.controller.internal.TargetClusterResourceProviderTest
org.apache.ambari.server.controller.internal.JobResourceProviderTest
org.apache.ambari.server.controller.internal.TaskAttemptResourceProviderTest
org.apache.ambari.server.controller.internal.FeedResourceProviderTest
org.apache.ambari.server.controller.internal.InstanceResourceProviderTest
org.apache.ambari.server.controller.internal.WorkflowResourceProviderTest
org.apache.ambari.server.api.query.QueryImplTest
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12601//console
This message is automatically generated.
> Remove properties.json And Switch To Adding Properties to ResourceProviders
> Dynamically
> ---------------------------------------------------------------------------------------
>
> Key: AMBARI-22353
> URL: https://issues.apache.org/jira/browse/AMBARI-22353
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Affects Versions: 3.0.0
> Reporter: Dmitry Lysnichenko
> Assignee: Dmitry Lysnichenko
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: AMBARI-22353.patch
>
>
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern
> which properties can be used with the provider. This seems like excessive
> decoupling without any benefit and usually leads to runtime errors when new
> or removed properties are forgotten.
> This file should be removed and the providers should be registering the known
> properties on their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
