[ 
https://issues.apache.org/jira/browse/AMBARI-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirill updated AMBARI-23665:
----------------------------
    Description: 
When custom service script contains the following:

{code}

    def configure(self, env, upgrade_type=None, config_dir=None):
        import params
        env.set_params(params)
        ExecuteScript(
                      code=constants.some_string,
                      interpreter='/usr/bin/env python',
                      )

{code}

service installation fails with:

{code}
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/customservice.py",
 line 82, in <module>
    CustomService().execute()
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 375, in execute
    method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/customservice.py",
 line 36, in install
    self.configure(env)
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 120, in locking_configure
    original_configure(obj, *args, **kw)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
 line 44, in configure
    interpreter='/usr/bin/env python',
TypeError: __new__() takes at least 2 arguments (1 given)
{code}

When {{ExecuteScript}} is called like:
{code}
    def configure(self, env, upgrade_type=None, config_dir=None):
        import params
        env.set_params(params)
        ExecuteScript('some-text',
                      code=constants.constants.some_string,
                      interpreter='/usr/bin/env python',
                      )
{code}

installation fails with:
{code}
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
 line 82, in <module>
    CustomService().execute()
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 375, in execute
    method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
 line 36, in install
    self.configure(env)
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 120, in locking_configure
    original_configure(obj, *args, **kw)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
 line 44, in configure
    interpreter='/usr/bin/env python',
  File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 166, 
in __init__
    self.env.run()
  File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
line 160, in run
    self.run_action(resource, action)
  File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
line 124, in run_action
    provider_action()
  File 
"/usr/lib/ambari-agent/lib/resource_management/core/providers/system.py", line 
277, in action_run
    preexec_fn=_preexec_fn(self.resource))
NameError: global name '_preexec_fn' is not defined
{code}

  was:
When custom service script contains the following:

{code}

    def configure(self, env, upgrade_type=None, config_dir=None):
        import params
        env.set_params(params)
        ExecuteScript(
                      code=constants.some_string,
                      interpreter='/usr/bin/env python',
                      )

{code}

service installation fails with:

{code}
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/hue.py",
 line 82, in <module>
    Hue().execute()
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 375, in execute
    method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/hue.py",
 line 36, in install
    self.configure(env)
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 120, in locking_configure
    original_configure(obj, *args, **kw)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/hue.py",
 line 44, in configure
    interpreter='/usr/bin/env python',
TypeError: __new__() takes at least 2 arguments (1 given)
{code}

When {{ExecuteScript}} is called like:
{code}
    def configure(self, env, upgrade_type=None, config_dir=None):
        import params
        env.set_params(params)
        ExecuteScript('some-text',
                      code=constants.constants.some_string,
                      interpreter='/usr/bin/env python',
                      )
{code}

installation fails with:
{code}
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/hue.py",
 line 82, in <module>
    Hue().execute()
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 375, in execute
    method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/hue.py",
 line 36, in install
    self.configure(env)
  File 
"/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
line 120, in locking_configure
    original_configure(obj, *args, **kw)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/hue.py",
 line 44, in configure
    interpreter='/usr/bin/env python',
  File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 166, 
in __init__
    self.env.run()
  File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
line 160, in run
    self.run_action(resource, action)
  File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
line 124, in run_action
    provider_action()
  File 
"/usr/lib/ambari-agent/lib/resource_management/core/providers/system.py", line 
277, in action_run
    preexec_fn=_preexec_fn(self.resource))
NameError: global name '_preexec_fn' is not defined
{code}


> ExecuteScript in resource_management is broken
> ----------------------------------------------
>
>                 Key: AMBARI-23665
>                 URL: https://issues.apache.org/jira/browse/AMBARI-23665
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-agent
>    Affects Versions: 2.6.1
>         Environment: Ambari 2.6.1.3 is installed as RPM from 
> [http://public-repo-1.hortonworks.com/ambari/centos7/2.x/updates/2.6.1.3] but 
> the code in {{trunk}} looks the same: 
> https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/core/providers/system.py
>            Reporter: Kirill
>            Priority: Major
>
> When custom service script contains the following:
> {code}
>     def configure(self, env, upgrade_type=None, config_dir=None):
>         import params
>         env.set_params(params)
>         ExecuteScript(
>                       code=constants.some_string,
>                       interpreter='/usr/bin/env python',
>                       )
> {code}
> service installation fails with:
> {code}
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/customservice.py",
>  line 82, in <module>
>     CustomService().execute()
>   File 
> "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
> line 375, in execute
>     method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/HUE/package/scripts/customservice.py",
>  line 36, in install
>     self.configure(env)
>   File 
> "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
> line 120, in locking_configure
>     original_configure(obj, *args, **kw)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
>  line 44, in configure
>     interpreter='/usr/bin/env python',
> TypeError: __new__() takes at least 2 arguments (1 given)
> {code}
> When {{ExecuteScript}} is called like:
> {code}
>     def configure(self, env, upgrade_type=None, config_dir=None):
>         import params
>         env.set_params(params)
>         ExecuteScript('some-text',
>                       code=constants.constants.some_string,
>                       interpreter='/usr/bin/env python',
>                       )
> {code}
> installation fails with:
> {code}
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
>  line 82, in <module>
>     CustomService().execute()
>   File 
> "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
> line 375, in execute
>     method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
>  line 36, in install
>     self.configure(env)
>   File 
> "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", 
> line 120, in locking_configure
>     original_configure(obj, *args, **kw)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.6/services/CUSTOM_SERVICE/package/scripts/customservice.py",
>  line 44, in configure
>     interpreter='/usr/bin/env python',
>   File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 
> 166, in __init__
>     self.env.run()
>   File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
> line 160, in run
>     self.run_action(resource, action)
>   File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", 
> line 124, in run_action
>     provider_action()
>   File 
> "/usr/lib/ambari-agent/lib/resource_management/core/providers/system.py", 
> line 277, in action_run
>     preexec_fn=_preexec_fn(self.resource))
> NameError: global name '_preexec_fn' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to