[
https://issues.apache.org/jira/browse/AMBARI-24743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641442#comment-16641442
]
ASF GitHub Bot commented on AMBARI-24743:
-----------------------------------------
g-boros commented on a change in pull request #4: AMBARI-24743. Cleanup
logsearch: add/cleanup javadoc.
URL: https://github.com/apache/ambari-logsearch/pull/4#discussion_r223262646
##########
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/DockerLogFileUpdateMonitor.java
##########
@@ -31,14 +31,15 @@
/**
* Periodically check docker containers metadata registry, stop monitoring
container log files if those do not exist or stopped too long time ago.
* If it finds a new container log for the specific type, it will start to
monitoring it.
- * <br/>
- * Use cases:<br/>
- * - input has not monitored yet - found new container -> start monitoring it
<br/>
- * - input has not monitored yet - found new stopped container -> start
monitoring it <br/>
- * - input has not monitored yet - found new stopped container but log is too
old -> do not monitoring it <br/>
- * - input has monitored already - container stopped - if it's stopped for too
long time -> remove it from the monitoed list<br/>
- * - input has monitored already - container stopped - log is not too old ->
keep in the monitored list <br/>
- * - input has monitored already - container does not exist - remove it from
the monitoed list (and all other input with the same log type) <br/>
+ * <pre>
+ * Use cases:
+ * - input has not monitored yet - found new container: start monitoring it
+ * - input has not monitored yet - found new stopped container: start
monitoring it
+ * - input has not monitored yet - found new stopped container but log is too
old: do not monitoring it
+ * - input has monitored already - container stopped - if it's stopped for too
long time : remove it from the monitoed list
+ * - input has monitored already - container stopped - log is not too old:
keep in the monitored list
+ * - input has monitored already - container does not exist - remove it from
the monitoed list (and all other input with the same log type)
Review comment:
typo: monitoed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cleanup logsearch: add/cleanup javadoc
> --------------------------------------
>
> Key: AMBARI-24743
> URL: https://issues.apache.org/jira/browse/AMBARI-24743
> Project: Ambari
> Issue Type: Task
> Components: ambari-logsearch
> Affects Versions: 2.7.0
> Reporter: Olivér Szabó
> Assignee: Olivér Szabó
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
