[
https://issues.apache.org/jira/browse/AMBARI-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645364#comment-16645364
]
ASF GitHub Bot commented on AMBARI-24692:
-----------------------------------------
adoroszlai commented on a change in pull request #7: AMBARI-24692. Use jdk8 as
default compiler version
URL: https://github.com/apache/ambari-logsearch/pull/7#discussion_r224186978
##########
File path: Makefile
##########
@@ -43,29 +43,26 @@ deb:
update-version:
$(MAVEN_BINARY) versions:set -DnewVersion=$(new-version)
-DgenerateBackupPoms=false
-package-jdk8:
- $(MAVEN_BINARY) clean package -Djdk.version=1.8
+package-jdk11:
+ $(MAVEN_BINARY) clean package -Djdk.version=11
Review comment:
Passing `jdk.version` from environment variable might help reduce
duplication of targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JDK 11 support for Log Search
> -----------------------------
>
> Key: AMBARI-24692
> URL: https://issues.apache.org/jira/browse/AMBARI-24692
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
> Affects Versions: 2.7.0
> Reporter: Olivér Szabó
> Assignee: Olivér Szabó
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)