[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683384#comment-16683384
]
ASF GitHub Bot commented on AMBARI-24833:
-----------------------------------------
kasakrisz commented on a change in pull request #19: AMBARI-24833. Re-implement
S3/HDFS outputs as global cloud outputs
URL: https://github.com/apache/ambari-logsearch/pull/19#discussion_r232563856
##########
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/cloud/upload/HDFSS3UploadClient.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.output.cloud.upload;
+
+import org.apache.ambari.logfeeder.conf.LogFeederProps;
+import org.apache.ambari.logfeeder.conf.output.S3OutputConfig;
+import org.apache.ambari.logfeeder.util.LogFeederHDFSUtil;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.s3a.SimpleAWSCredentialsProvider;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.IOException;
+
+public class HDFSS3UploadClient extends AbstractCloudClient implements
UploadClient<S3OutputConfig> {
+
+ private static final Logger logger =
LogManager.getLogger(HDFSS3UploadClient.class);
+
+ private final S3OutputConfig s3OutputConfig;
+
+ private FileSystem fs;
+
+ public HDFSS3UploadClient(S3OutputConfig s3OutputConfig) {
+ this.s3OutputConfig = s3OutputConfig;
+ }
+
+ @Override
+ void createBucketIfNeeded(String bucket) {
+ logger.warn("HDFS based S3 client won't bootstrap default bucket ('{}')",
s3OutputConfig.getBucket());
+ }
+
+ @Override
+ public void init(LogFeederProps logFeederProps) {
+ SecretKeyPair keyPair = getSecretKeyPair(logFeederProps, s3OutputConfig);
+ // TODO: load configuration from file
+ Configuration conf =
LogFeederHDFSUtil.buildHdfsConfiguration(s3OutputConfig.getBucket(), "s3a");
+ conf.set("fs.s3a.access.key", new String(keyPair.getAccessKey()));
+ conf.set("fs.s3a.secret.key", new String(keyPair.getSecretKey()));
+ conf.set("fs.s3a.aws.credentials.provider",
SimpleAWSCredentialsProvider.NAME);
+ conf.set("fs.s3a.endpoint", s3OutputConfig.getEndpoint());
+ conf.set("fs.s3a.path.style.access",
String.valueOf(s3OutputConfig.isPathStyleAccess()));
+ conf.set("fs.s3a.multiobjectdelete.enable",
String.valueOf(s3OutputConfig.isMultiobjectDeleteEnable()));
+ this.fs = LogFeederHDFSUtil.buildFileSystem(conf);
+ }
+
+ @Override
+ public boolean upload(String source, String target, String basePath) {
+ return LogFeederHDFSUtil.copyFromLocal(source, target, this.fs, true,
true, null);
+ }
+
+ @Override
+ public S3OutputConfig getOutputConfig() {
+ return this.s3OutputConfig;
+ }
+
+ @Override
+ public void close() throws IOException {
+ if (fs != null) {
Review comment:
You can use
```org.apache.commons.io.IOUtils.closeQuietly(fs);```
if logging the IOException is not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
> ----------------------------------------------------
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
> Affects Versions: 2.7.0
> Reporter: Olivér Szabó
> Assignee: Olivér Szabó
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
