[
https://issues.apache.org/jira/browse/AMBARI-24551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684088#comment-16684088
]
ASF GitHub Bot commented on AMBARI-24551:
-----------------------------------------
tobias-istvan commented on issue #5: [AMBARI-24551] [Log Search UI] get rid of
redundant requests after undoing or redoing several history steps
URL: https://github.com/apache/ambari-logsearch/pull/5#issuecomment-437956593
@aBabiichuk
I completely refactored the history manager. The initial reason was to
simplify the business logic around the history management, also make it more
URL handling compatible since the history is connected to the linkable URL.
I followed the previous approach which is use more action/effects/reducers
over services in order to decouple the direct dependencies.
The main reason of the redundant request was the wrong implementation of the
`ControlValueAccessor` interface.
I also added some UX improvements to indicate when a request is in progress
in the background. There is a global notification and added some specific ones
for log tables and graphs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Log Search UI] get rid of redundant requests after undoing or redoing
> several history steps
> --------------------------------------------------------------------------------------------
>
> Key: AMBARI-24551
> URL: https://issues.apache.org/jira/browse/AMBARI-24551
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch, logsearch
> Affects Versions: 2.7.1
> Reporter: Istvan Tobias
> Assignee: Istvan Tobias
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Original Estimate: 4h
> Time Spent: 3.5h
> Remaining Estimate: 0.5h
>
> After undoing or redoing more than one history items several redundant API
> requests are sent. This occurs because changes for several filter controls
> are applied step-by-step, and each control change generates new request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
