[
https://issues.apache.org/jira/browse/AMBARI-24882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693339#comment-16693339
]
ASF GitHub Bot commented on AMBARI-24882:
-----------------------------------------
tobias-istvan opened a new pull request #32: [AMBARI-24882] [Log Search UI]
Change sticky filter panel solution from JS to clean css.
URL: https://github.com/apache/ambari-logsearch/pull/32
# What changes were proposed in this pull request?
I removed the JavaScript scroll listener and changed to the `position:
sticky` solution since the only browser which does not support is IE11 but even
there the functionality won't break at all.
## How was this patch tested?
It was tested manually, and by running unit tests:
```
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 292 of 292 SUCCESS (15.13 secs /
14.97 secs)
✨ Done in 45.62s.
```
Please review [Ambari Contributing
Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute)
before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Log Search UI] Change sticky filter panel solution from JS to clean css.
> -------------------------------------------------------------------------
>
> Key: AMBARI-24882
> URL: https://issues.apache.org/jira/browse/AMBARI-24882
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-logsearch, logsearch
> Reporter: Istvan Tobias
> Assignee: Istvan Tobias
> Priority: Major
> Labels: pull-request-available
>
> Instead of listening scroll event we can use `sticky` css `position`. It is
> not supported by all the browsers (IE does not support). This does not break
> functionality but improve performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
