[
https://issues.apache.org/jira/browse/AMBARI-18361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707147#comment-16707147
]
ASF GitHub Bot commented on AMBARI-18361:
-----------------------------------------
adoroszlai closed pull request #22: [AMBARI-18361] Avoid unnecessary compilation
URL: https://github.com/apache/ambari-infra/pull/22
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ambari-infra-manager/pom.xml b/ambari-infra-manager/pom.xml
index d595f997..097455dc 100644
--- a/ambari-infra-manager/pom.xml
+++ b/ambari-infra-manager/pom.xml
@@ -51,11 +51,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.0</version>
- <configuration>
- <source>${jdk.version}</source>
- <target>${jdk.version}</target>
- </configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
@@ -303,7 +298,7 @@
<artifactId>jersey-media-json-jettison</artifactId>
<version>${jersey.version}</version>
</dependency>
-
+
<dependency>
<groupId>org.apache.solr</groupId>
<artifactId>solr-solrj</artifactId>
diff --git a/ambari-infra-solr-plugin/pom.xml b/ambari-infra-solr-plugin/pom.xml
index 9de8e72f..e9bec086 100644
--- a/ambari-infra-solr-plugin/pom.xml
+++ b/ambari-infra-solr-plugin/pom.xml
@@ -60,11 +60,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.3</version>
- <configuration>
- <source>${jdk.version}</source>
- <target>${jdk.version}</target>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -90,4 +85,4 @@
</plugin>
</plugins>
</build>
-</project>
\ No newline at end of file
+</project>
diff --git a/pom.xml b/pom.xml
index b6f52f9c..af47dc8f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -194,10 +194,11 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.2</version>
+ <version>3.3</version>
<configuration>
<source>${jdk.version}</source>
<target>${jdk.version}</target>
+ <useIncrementalCompilation>false</useIncrementalCompilation>
</configuration>
</plugin>
<plugin>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> All classes recompiled due to Maven bug, even if none changed
> -------------------------------------------------------------
>
> Key: AMBARI-18361
> URL: https://issues.apache.org/jira/browse/AMBARI-18361
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.4.0
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.5.0
>
> Attachments: AMBARI-18361.patch
>
>
> maven-compiler-plugin version 3.0 has a
> [bug|https://issues.apache.org/jira/browse/MCOMPILER-187] that causes all
> classes to be recompiled even if no classes have changed.
> {noformat}
> [INFO] --- maven-compiler-plugin:3.0:compile (default-compile) @
> ambari-server ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1720 source files ...
> ...
> [INFO] --- maven-compiler-plugin:3.0:testCompile (default-testCompile) @
> ambari-server ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 760 source files ...
> {noformat}
> version 3.1+ has [another, related
> bug|https://issues.apache.org/jira/browse/MCOMPILER-209] that causes all
> classes to be compiled even if only one has changed, although it seems to
> correctly detect the "no change" case.
> {noformat}
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @
> ambari-server ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1720 source files ...
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
