[
https://issues.apache.org/jira/browse/AMBARI-23456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710079#comment-16710079
]
ASF GitHub Bot commented on AMBARI-23456:
-----------------------------------------
kasakrisz commented on a change in pull request #54: AMBARI-23456. Add mkdocs
support & markdown skeletons
URL: https://github.com/apache/ambari-logsearch/pull/54#discussion_r239062724
##########
File path:
ambari-logsearch-config-json/src/main/java/org/apache/ambari/logsearch/config/json/model/inputconfig/impl/InputS3FileDescriptorImpl.java
##########
@@ -34,7 +34,7 @@
@ShipperConfigElementDescription(
path = "/input/[]/s3_access_key",
type = "string",
- description = "The access key used for AWS credentials."
+ description = "The access key used for AWS credentials. (Not supported yet
through shipper configurations)"
Review comment:
Is it possible to omit these not supported properties from the doc? I think
these should only be included if the functionality is supported.
lines: 37, 46, 55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Log Search: generate mardown docs for properties and logfeeder configs based
> on annotations
> -------------------------------------------------------------------------------------------
>
> Key: AMBARI-23456
> URL: https://issues.apache.org/jira/browse/AMBARI-23456
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
> Affects Versions: 2.8.0
> Reporter: Olivér Szabó
> Assignee: Olivér Szabó
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
