[
https://issues.apache.org/jira/browse/AMBARI-25116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756223#comment-16756223
]
Hudson commented on AMBARI-25116:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10443 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/10443/])
AMBARI-25116. Fix other strange and buggy code (dlysnichenko) (#2785) (github:
[https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=cbd628460a186991f8cf2c391657eb5891c2ab82])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/checks/PluginChecksLoadedCheck.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
* (edit) ambari-server/pom.xml
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/NameNodeHaValidatorTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/ScriptRunner.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/ColocatedGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerStackAdvisorAwareConfigurationHandler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/services/PersistenceManagerImplTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/UpgradeUpdateListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/utils/MpackVersion.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/StompEventsMetricsSource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/orchestrate/UpgradeHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/MpackResourceDefinition.java
* (edit)
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackResourceDefinition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/ClusterGrouping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/StackAdvisorAdapter.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerLDAPConfigurationHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/ConfigureTask.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java
> Bug at AbstractProviderModule class
> -----------------------------------
>
> Key: AMBARI-25116
> URL: https://issues.apache.org/jira/browse/AMBARI-25116
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Reporter: Dmitry Lysnichenko
> Assignee: Dmitry Lysnichenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Here
> org/apache/ambari/server/controller/internal/AbstractProviderModule.java:974
> there is a return statement within a loop without any condition. It is a
> definite bug
> {code}
> for (Resource res : configResources) {
> return res.getPropertiesMap().get(PROPERTIES_CATEGORY);
> }
> return Collections.emptyMap();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
