[
https://issues.apache.org/jira/browse/AMBARI-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhiguo Wu updated AMBARI-25859:
-------------------------------
Description:
Currently Ambari Metrics uses *2.0.0.0-SNAPSHOT* as its version number, and the
regex
{*}^([0-9]{+})\.([0-9]{+})\.([0-9]{+})\.([0-9]{+})((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).)?{*}*
and get *$7* as its release version number, but when we remove *SNAPSHOT*
suffix, the parse will return empty value cause build rpm package fails.
If I understand it correctly, the old logic is trying to get number(or word
*SNAPSHOT* or {*}techwin{*}) after the symbol "-" as its release version, so
I'd like to change the version format to *x.y.z-p* where *x.y.z* means ambari
version and *p* means release(or patch) version.(if the branch is under
development, we can use *SNAPSHOT* for {*}p{*})
Like this:
!image-2023-02-22-16-49-06-587.png!
was:
Currently Ambari Metrics uses *2.0.0.0-SNAPSHOT* as its version number, and the
regex
*^([0-9]{+})\.([0-9]{+})\.([0-9]{+})\.([0-9]{+})((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).)?**
and get *$7* as its release version number, but when we remove *SNAPSHOT*
suffix, the parse will return empty value cause build rpm package fails.
If I understand it correctly, the old logic is trying to get number(or word
*SNAPSHOT* or {*}techwin{*}) after the symbol "-" as its release version, so
I'd like to change the version format to *x.y.z-p* where *x.y.z* means ambari
version and *p* means patch version in SPEC file.(if the branch is under
development, we can use *SNAPSHOT* for {*}p{*})
Like this:
!image-2023-02-22-16-49-06-587.png!
> Correct Ambari Metrics version parsing logic
> --------------------------------------------
>
> Key: AMBARI-25859
> URL: https://issues.apache.org/jira/browse/AMBARI-25859
> Project: Ambari
> Issue Type: Bug
> Reporter: Zhiguo Wu
> Assignee: Zhiguo Wu
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2023-02-22-16-49-06-587.png
>
>
> Currently Ambari Metrics uses *2.0.0.0-SNAPSHOT* as its version number, and
> the regex
> {*}^([0-9]{+})\.([0-9]{+})\.([0-9]{+})\.([0-9]{+})((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).)?{*}*
> and get *$7* as its release version number, but when we remove *SNAPSHOT*
> suffix, the parse will return empty value cause build rpm package fails.
>
> If I understand it correctly, the old logic is trying to get number(or word
> *SNAPSHOT* or {*}techwin{*}) after the symbol "-" as its release version, so
> I'd like to change the version format to *x.y.z-p* where *x.y.z* means ambari
> version and *p* means release(or patch) version.(if the branch is under
> development, we can use *SNAPSHOT* for {*}p{*})
>
> Like this:
> !image-2023-02-22-16-49-06-587.png!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
