liruohrh commented on PR #1451: URL: https://github.com/apache/answer/pull/1451#issuecomment-3632542231
yes, it shoule be in .env*.local. it like dir /data. like `REACT_APP_API_URL = http://10.0.20.84:8080/` in .env.development, i need .env.local to set to`http://127.0.0.1/`. "merging custom and built-in" is my way to handle custom i18n(by write /cmd/i18nmerge in my local repo). I think perhaps others might need it too, so I created this pr, for if has the env, we do not need to modify ui/config-overrides.js. actually it must alaways is /data/i18n （same with backend i18n in data dir）. > such as, i run /cmd/i18nmerge to merge /data/i18n and /answer/myi18n to /data/i18n, backend and frontend both use /data/i18n. (/answer/ is the source code repo). > [create-answer-plugin](https://github.com/answerdev/create-answer-plugin). also use ANSWER_I18N_PATH(which will invoke `answer i18n` after install plugin to merge plugin i18n). for create-answer-plugin, i decide to change ANSWER_I18N_ROOT to ANSWER_I18N_PATH. and i add some code comments for ANSWER_I18N_PATH. so, how do you feel now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
