[
http://jira.codehaus.org/browse/MRM-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146560#action_146560
]
Maria Odea Ching commented on MRM-90:
-------------------------------------
Thanks for the patch Gwen, it looks great!
I just have a couple of comments though..
- could you provide unit tests for the filtered search in
DefaultCrossRepositorySearch?
- from the filtered search page, maybe we could add a link that would take the
user back to the quickSearch page?
- i think we could already remove the Filter Results and Search Results Only
checkboxes as the filtered search is already an exact search. wdyt?
- there's a problem with the results count (sometimes the starting count is
negative and the succeeding page # links doesn't show up)
- in CrossRepositorySearch, maybe we could rename the filterSearchResults(..)
method to let's say doFilteredSearch(..) or executeFilteredSearch() for
clarity?
- the search criteria doesn't seem to be AND'ed.. when i entered a groupId of
an artifact and a class/package name of another (different) artifact then did a
search, both artifacts were returned even though they don't satisfy BOTH of the
criteria i entered (they only satisfy one of the criteria -- either groupId OR
class/package name)
> add advanced search options
> ---------------------------
>
> Key: MRM-90
> URL: http://jira.codehaus.org/browse/MRM-90
> Project: Archiva
> Issue Type: New Feature
> Components: web application
> Reporter: Brett Porter
> Fix For: Future
>
> Attachments: MRM-90.patch
>
>
> we need to add the ability to query on particular fields and across some
> ranges.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
