RepositoryServlet tests fail intermittently on Windows
------------------------------------------------------
Key: MRM-1004
URL: http://jira.codehaus.org/browse/MRM-1004
Project: Archiva
Issue Type: Bug
Components: build
Affects Versions: 1.2-M1
Environment: Windows
Reporter: Martin Cooper
Attachments: close_reader.patch
The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail
on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is
using. The bug is that MavenXpp3Reader does not close the Reader after reading
the content of a POM. Thus the file is left open until the MavenXpp3Reader
instance is garbage collected. Since the garbage collector is run whenever the
JVM feels like it, the problem is intermittent rather than being consistent.
Although the root of the problem is with Maven's MavenXpp3Reader class, there
is a simple workaround that can be applied to the Archiva code. That is to
close the reader explicitly, after the POM content has been read. This will not
cause a problem when the Maven bug is fixed, since closing an already-closed
Reader is a no-op.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
