[
http://jira.codehaus.org/browse/MRM-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Cooper updated MRM-962:
------------------------------
Attachment: mrm-962.patch
I don't believe that the earlier patch is sufficient. While it corrects the
problem with the ArtifactReference instance, it leaves subsequent uses of the
fields unaltered, so that the untrimmed values are used if / when a POM is
created and for log and audit messages. The cleanest way to resolve this is to
trim the values as they are supplied, such that all subsequent uses will be of
trimmed values. The attached patch uses StringUtils.trim to do this so that no
special casing is required if a null value is somehow provided.
> Upload Artifact action should trim its fields
> ---------------------------------------------
>
> Key: MRM-962
> URL: http://jira.codehaus.org/browse/MRM-962
> Project: Archiva
> Issue Type: Bug
> Components: web application
> Affects Versions: 1.1.2
> Environment: Client: Windows XP SP3, Firefox 3.0.3
> Server: Linux Red Hat AS 4.0
> Reporter: Vincent Thévenin
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: Archiva_issue.zip, mrm-962.patch, MRM-962.patch
>
>
> Fields from 'Upload Artifact' form are not trimmed, resulting in artifacts
> that may not be reachable afterward.
> As an example, see attached archive.
> Step_1: inserting an artifact with spaces in the groupId and artifactId fields
> Step_2: the artifact is accepted with no error
> Step_3: when trying, for example, to browse the artifact, it is of course
> unreachable
> Fields involved are: Group Id, Artifact Id, Packaging, Classifier
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
