[ 
http://jira.codehaus.org/browse/MRM-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194497#action_194497
 ] 

Maria Odea Ching edited comment on MRM-747 at 10/12/09 11:11 PM:
-----------------------------------------------------------------

Hi Marc, I reviewed and applied your patch locally and it works nicely :) I 
have a concern regarding the following line in the patch though as it only 
limits the blocking of re-deployment of released artifacts to "jar" files:
{code}
+                       if (StringUtils.equals("jar", artifact.getType()) &&
+                                       
artifact.getVersion().indexOf("SNAPSHOT")== -1  )
{code}

I think it shouldn't be limited to jar artifacts only. Was there a reason 
behind this that I might have missed?

      was (Author: oching):
    Hi Marc, I reviewed and applied your patch locally and it works nicely :) I 
have a concern regarding the following line in the patch though as it only 
limits the blocking of re-deployment of released artifacts to "jar" files:
{code}
+                       if (StringUtils.equals("jar", artifact.getType()) &&
+                                       
artifact.getVersion().indexOf("SNAPSHOT")== -1  )
{code}

I think it shouldn't be limited to jar artifacts only. Anyway, was there a 
reason behind this that I might have missed?
  
> Archiva should prevent re-deployment of released or non-snapshot versioned 
> artifacts
> ------------------------------------------------------------------------------------
>
>                 Key: MRM-747
>                 URL: http://jira.codehaus.org/browse/MRM-747
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0.1
>            Reporter: Alexandre Navarro
>            Assignee: Maria Odea Ching
>             Fix For: 1.2.3
>
>         Attachments: ArchivaDavResourceFactory.java, MRM-747.diff, 
> MRM-747.svndiff, MRM-747_trunk.diff, 
> ReleaseArtifactAlreadyExistsException.java
>
>
> It is possible de redeploy a versionned jar with webdav eventhough it must be 
> impossible.
> It is possible de redeploy a versionned jar eventhough the file is readonly.
> It is very problematic.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to