[
http://jira.codehaus.org/browse/MRM-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209101#action_209101
]
Brett Porter commented on MRM-1304:
-----------------------------------
the patch looks fine, and thanks for adding a test!
I would only nitpick a couple of things:
- please fix the formatting in the patch
(http://archiva.apache.org/developers/how-we-do-things.html). You might like to
get the IDE code settings from the Maven site and use that to reformat your
changes
- modifiedGroup can be created in the block - there's no reason for it to exist
outside the if (nor be initialised separately).
> Query using Group ID field in audit log report uses '/' as a separator
> instead of '.'
> -------------------------------------------------------------------------------------
>
> Key: MRM-1304
> URL: http://jira.codehaus.org/browse/MRM-1304
> Project: Archiva
> Issue Type: Bug
> Components: reporting, web application
> Reporter: Maria Odea Ching
> Assignee: Maria Odea Ching
> Fix For: 1.3.1
>
> Attachments: MRM-1304.patch, MRM-1304.patch, Updated_MRM-1304.patch
>
>
> For groupIds with '.' (e.g. com.mycompany), you should use '/' instead (e.g.
> com/mycompany) as the artifact details are stored as artifact paths.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
