[ 
http://jira.codehaus.org/browse/MRM-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236841#action_236841
 ] 

Maria Odea Ching commented on MRM-1409:
---------------------------------------

Thanks for the patch Gwen :) A couple of minor comments though:

* There's a missing 'e' in 'Triggred' in the ff. line for AuditEvent:

{code}
+    public static final String MERGE_REPO_REMOTE = "Merged Staging Repository 
Triggred Remotely";
{code}

* For RepositoryMerger, it might be better to rename the following method to 
getConflictingArtifacts(..)

{code}
+    public List<ArtifactMetadata> getConflictsartifacts( String sourceRepo, 
String targetRepo )
+        throws Exception;
{code}

* In AdministrationServiceImpl, what is the call to .removeAll(..) for since 
conflicts is an empty list?

{code}
+        List<ArtifactMetadata> conflicts = new ArrayList<ArtifactMetadata>();
+        sources.removeAll( conflicts );
{code}

* Lastly, you can already remove the <version>${project.version}</version> in 
the dependencies that you've added in the respective POMs since the version is 
already specified in the root POM


> Web services for repository merging or artifact promotion
> ---------------------------------------------------------
>
>                 Key: MRM-1409
>                 URL: http://jira.codehaus.org/browse/MRM-1409
>             Project: Archiva
>          Issue Type: New Feature
>          Components: XMLRPC Interface
>            Reporter: Maria Odea Ching
>             Fix For: 1.4
>
>         Attachments: archiva.patch, updated-MRM-1409.patch
>
>
> I think CRUD for managed repositories should be a pre-requisite of this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to