[
https://jira.codehaus.org/browse/MRM-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MRM-1434:
------------------------------
Fix Version/s: (was: 2.1.0)
2.1.1
> Suspicious RepositoryMetadataMerge.clonePlugins
> ------------------------------------------------
>
> Key: MRM-1434
> URL: https://jira.codehaus.org/browse/MRM-1434
> Project: Archiva
> Issue Type: Bug
> Reporter: Dave Brosius
> Assignee: Maria Odea Ching
> Priority: Minor
> Fix For: 2.1.1
>
>
> The method RepositoryMetadataMerge.clonePlugins seems oddly wrong to me, it
> clones a plugin, but then doesn't use the clone, but uses the original
> private static List<Plugin> clonePlugins(List<Plugin> plugins)
> {
> if (plugins == null)
> {
> return null;
> }
>
> List<Plugin> result = new ArrayList<Plugin>();
>
> for (Plugin plugin : plugins)
> {
> Plugin clonedPlugin = new Plugin();
> clonedPlugin.setArtifactId(plugin.getArtifactId());
> clonedPlugin.setName(plugin.getName());
> clonedPlugin.setPrefix(plugin.getPrefix());
> result.add(plugin);
> <======= should this be clonedPlugin ?
> }
>
> return result;
> }
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
