[ 
https://jira.codehaus.org/browse/MRM-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=353165#comment-353165
 ] 

Jonathan Sharp commented on MRM-1311:
-------------------------------------

Right now, the consumers in package org.apache.archiva.consumers.core -- 
ValidateChecksumConsumer, ArtifactMissingChecksumConsumer, AutoRemoveConsumer, 
AutoRenameConsumer, & MetadataUpdaterConsumer -- call the inherited methods 
(AbstractMonitoredConsumer's triggerConsumerError, triggerConsumerWarning, 
triggerConsumerInfo) without using a Logger. (MetadataUpdaterConsumer logs 
debug messages separately.)

It looks like a simple fix would be to add logging to each of these classes and 
leave the existing calls as they are.

As Brett mentioned, nothing in archiva calls addConsumerMonitor and nothing 
implements ConsumerMonitor. Also, many other consumer classes extend 
AbstractMonitoredConsumer but do not call triggerConsumerError, 
triggerConsumerWarning, or triggerConsumerInfo. So it is a question whether we 
want to increase usage of these three methods and keep the ConsumerMonitor 
interface, or when to get rid of them.

> Logging in ArtifactMissingChecksumsConsumer does not appear in the logs even 
> if configured properly
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1311
>                 URL: https://jira.codehaus.org/browse/MRM-1311
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Maria Odea Ching
>             Fix For: 2.1.2
>
>
> The logging needs to be migrated to use the Logger class, similar to the 
> other consumers.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to