[ 
https://issues.apache.org/jira/browse/ARIA-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036232#comment-16036232
 ] 

ASF GitHub Bot commented on ARIA-254:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r120005385
  
    --- Diff: tests/end2end/test_nodecellar.py ---
    @@ -39,4 +39,4 @@ def _verify_deployed_service_in_storage(service_name, 
model_storage):
         service = service_templates[0].services[service_name]
         assert service.name == service_name
         assert len(service.executions) == 0  # dry executions leave no traces
    -    assert len(service.nodes) == 10
    +    assert len(service.nodes) == 13
    --- End diff --
    
    why 13? I though you added just one other instance


> Support multiple nodes of a node template at service creation time
> ------------------------------------------------------------------
>
>                 Key: ARIA-254
>                 URL: https://issues.apache.org/jira/browse/ARIA-254
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>            Priority: Critical
>
> Currently each node template can only have a single node.
> We need to support having multiple nodes of a given node-template at service 
> creation time. The mechanism for this should take into consideration future 
> stories which would require allowing scaling the number of nodes of a 
> node-template up or down.
> Note: the term {{default_instances}} appears in several places in the code 
> ([1|https://github.com/apache/incubator-ariatosca/blob/1f3e7ff42fefcd5dc8191e3b0eeac0460db059b0/extensions/aria_extension_tosca/profiles/tosca-simple-1.0/capabilities.yaml#L151],
>  
> [2|https://github.com/apache/incubator-ariatosca/blob/fdd57c47acfe63dc25c6f20bcb3785225b3f774d/aria/modeling/service_template.py#L310],
>  
> [3|https://github.com/apache/incubator-ariatosca/blob/60ea3ebb21e762d36115db26563a93dd3cb72003/extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py#L163])
>  - we could perhaps use this or an extension based on this idea to support 
> this issue.
> One other thing that should be taken into consideration (but perhaps be moved 
> to a separate JIRA issue) is the implicit declaration of multiple instances 
> via the capabilities&requirements mechanism in TOSCA - We need to decide if 
> to support this as well or not, and if we do, how does this play together 
> with the primary method of declaring multiple nodes (or perhaps would this be 
> the only method of doing so?)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to