[
https://issues.apache.org/jira/browse/ARIA-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036242#comment-16036242
]
ASF GitHub Bot commented on ARIA-260:
-------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/145#discussion_r120006635
--- Diff: tests/end2end/test_nodecellar.py ---
@@ -40,3 +40,21 @@ def _verify_deployed_service_in_storage(service_name,
model_storage):
assert service.name == service_name
assert len(service.executions) == 0 # dry executions leave no traces
assert len(service.nodes) == 10
+ assert
set(service.nodes['loadbalancer_host_1'].interfaces['Standard'].operations['create']
\
--- End diff --
While these additions are fine, I think this JIRA really calls for unit
tests which will check the various options for passing in arguments and verify
everything overrides what it should and only that.
There are many such scenarios, and you don't want to test them all in e2e
tests.
> Send interface inputs as arguments to operations
> ------------------------------------------------
>
> Key: ARIA-260
> URL: https://issues.apache.org/jira/browse/ARIA-260
> Project: AriaTosca
> Issue Type: Story
> Reporter: Tal Liron
> Assignee: Tal Liron
>
> We currently send all operation inputs as arguments to the task function.
> However, we are utterly ignoring interface inputs. The task function can of
> course retrieve them in complicated ways from the context, but it seems that
> for completion the interface inputs should be sent to the function in same
> way as operation inputs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
