[ 
https://issues.apache.org/jira/browse/ARIA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036316#comment-16036316
 ] 

ASF GitHub Bot commented on ARIA-262:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/141#discussion_r120013542
  
    --- Diff: aria/storage/core.py ---
    @@ -165,3 +166,19 @@ def drop(self):
             """
             for mapi in self.registered.values():
                 mapi.drop()
    +
    +    @contextmanager
    +    def instrument(self, *instrumentation):
    +
    +        def _instrument(remove=False):
    +            for mapi in self.registered.values():
    +                for field in instrumentation:
    +                    if remove is False:
    +                        mapi._instrumentation.append(field)
    --- End diff --
    
    extend


> Inconsistent node attributes behavior
> -------------------------------------
>
>                 Key: ARIA-262
>                 URL: https://issues.apache.org/jira/browse/ARIA-262
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Maxim Orlov
>            Assignee: Maxim Orlov
>
> ARIA provides sugaring for node attributes. However this sugaring is somewhat 
> limited, as it sugars ctx accessed attributes. e.g. Under 
> NodeOperationContext {{ctx.node.attributes}} has a dict-like behavior, where 
> the value is another object with a dict-like behavior. This is provided by 
> the sugaring. 
> However {{ctx.node.relationships[0].target_node.attributes}} provides a dict 
> where the value is of type Parameter, accessing the value of this Parameter 
> requires {{param.value}} This creates inconsistency with regards to access to 
> attributes.
> There are several possible solutions:
> 1. Enable sugaring on the model level. this will effectively make the 
> creation of Parameter implicit, but this will be possible throughout the 
> entire code (not only under context).
> 2. Enable sugaring by tapping to sqla events and altering the return values. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to